Re: [PATCH] palm_bk3710: fix resource management (take 2)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello.

Bartlomiej Zolnierkiewicz wrote:
On Monday 16 June 2008, Sergei Shtylyov wrote:
The driver expected a *virtual* address in the IDE platform device's memory
resource and didn't request the memory region for the register block. Fix this
taking into account the fact that DaVinci SoC devices are fixed-mapped to the
virtual memory early and we can get their virtual addresses using IO_ADDRESS()
macro, not having to call ioremap()...

While at it, also do some cosmetic changes...

Signed-off-by: Sergei Shtylyov <sshtylyov@xxxxxxxxxxxxx>

---
Argh! I have finally run checkpatch.pl and it detected some whitespace damage.
And of course, I then re-sent it without fixing that!
So, here's take 2 of that stupid patch for real now. Sorry for the mess... :-<

I've already fixed it while applying "take 1" but I was too lazy to
mention it (not that single " " removal is worth mentioning)... :)

I do that kind of mistakes in reject resolution very rarely. This just wasn't my day it seems... :-)

[ However please integrate checkpatch.pl into your workflow... ]

The forgotten signoff is surely my problem, so indeed I should... if I don't forget. ;-)

WBR. Sergei


--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux