On Sat, Jun 14, 2008 at 07:29:05PM +0200, Bartlomiej Zolnierkiewicz wrote:
> On Thursday 12 June 2008, Borislav Petkov wrote:
> > Use the generic ide_pad_transfer() helper instead
> >
> > Signed-off-by: Borislav Petkov <petkovbb@xxxxxxxxx>
>
> applied w/ ide_cd_drain_data() -> ide_pad_transfer() conversion fixup
>
> [...]
>
> > @@ -1006,7 +981,7 @@ static ide_startstop_t cdrom_newpc_intr(ide_drive_t *drive)
> > - bio_cur_sectors(rq->bio),
> > thislen >> 9);
> > if (nskip > 0) {
> > - ide_cd_drain_data(drive, nskip);
> > + ide_pad_transfer(drive, write, nskip);
> > rq->current_nr_sectors -= nskip;
> > thislen -= (nskip << 9);
> > }
>
> ide_cd_drain_data() took number for _sectors_ as an argument
> while ide_pad_transfer() wants to be given number of _bytes_
/me crawls ashamed back into the black place behind the wall cardboard ... :)
>
> > @@ -1043,7 +1018,7 @@ static ide_startstop_t cdrom_newpc_intr(ide_drive_t *drive)
> > * If the buffers are full, pipe the rest into
> > * oblivion.
> > */
> > - ide_cd_drain_data(drive, thislen >> 9);
> > + ide_pad_transfer(drive, 0, thislen >> 9);
>
> ditto
--
Regards/Gruß,
Boris.
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
