On Thursday 12 June 2008, Borislav Petkov wrote: > ... into cdrom_handle_failed_pc_req(). I actually think that we should try to unite pc/fs error handling as much as possible as it shouldn't really matter if i.e. READ command came through fs or pc request - the error handling w.r.t. hardware should be the same (at the moment it is not always the case - the most blatant example of this disrepancy is handling of NOT_READY sense key for WRITE commands). When I was suggesting factoring out error handling I rather meant moving out _everything_ after OK_STAT() (sorry for the confusion). On the second thought we may do it in even simpler way by moving: ... /* check for errors */ stat = ide_read_status(drive); if (stat_ret) *stat_ret = stat; if (OK_STAT(stat, good_stat, BAD_R_STAT)) return 0; ... to cdrom_decode_status() users and passing as an argument 'stat' instead of 'good_stat' and 'stat_ret'. Therefore I skipped this patch (and also patch #4) for now. -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
