Hi, On Thu, 5 Jun 2008, James Bottomley wrote: > I'm also not keen on the use of current->stack. It looks like this > commit: > > commit f7e4217b007d1f73e7e3cf10ba4fea4a608c603f > Author: Roman Zippel <zippel@xxxxxxxxxxxxxx> > Date: Wed May 9 02:35:17 2007 -0700 > > rename thread_info to stack > > Introduced a task_stack_page() accessor to get this instead, so perhaps > we should use it (I've cc'd Roman and linux-arch for opinions). This helper was mainly introduced to help with the transition from direct thread_info access. I don't see this field go away or change somehow in the near future, so direct access of stack is IMO ok, but we already have the helper, so using it to improve readability is fine too. bye, Roman -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
