Re: [PATCH 02/03] sata_mv: PHY_MODEx errata fixes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Mark Lord wrote:
Fix and update the errata handling for the PHY_MODEx registers.
This improves receiver noise tolerance, among other things.

Signed-off-by: Mark Lord <mlord@xxxxxxxxx>

--- old/drivers/ata/sata_mv.c    2008-05-27 11:53:01.000000000 -0400
+++ linux/drivers/ata/sata_mv.c    2008-05-27 12:01:25.000000000 -0400
@@ -2546,7 +2546,7 @@
        hp_flags & (MV_HP_ERRATA_60X1B2 | MV_HP_ERRATA_60X1C0);
    int fix_phy_mode4 =
        hp_flags & (MV_HP_ERRATA_60X1B2 | MV_HP_ERRATA_60X1C0);
-    u32 m2, tmp;
+    u32 m2, m3;

    if (fix_phy_mode2) {
        m2 = readl(port_mmio + PHY_MODE2);
@@ -2563,27 +2563,27 @@
        udelay(200);
    }

-    /* who knows what this magic does */
-    tmp = readl(port_mmio + PHY_MODE3);
-    tmp &= ~0x7F800000;
-    tmp |= 0x2A800000;
-    writel(tmp, port_mmio + PHY_MODE3);
+    /*
+     * Gen-II/IIe PHY_MODE3 errata RM#2:
+     * Achieves better receiver noise performance than the h/w default:
+     */
+    m3 = readl(port_mmio + PHY_MODE3);
+    m3 = (m3 & 0x1f) | (0x5555601 << 5);
+    writel(m3, port_mmio + PHY_MODE3);

    if (fix_phy_mode4) {
        u32 m4;

        m4 = readl(port_mmio + PHY_MODE4);

-        if (hp_flags & MV_HP_ERRATA_60X1B2)
-            tmp = readl(port_mmio + PHY_MODE3);
-
        /* workaround for errata FEr SATA#10 (part 1) */
        m4 = (m4 & ~(1 << 1)) | (1 << 0);

-        writel(m4, port_mmio + PHY_MODE4);
+        /* enforce bit restrictions on GenIIe devices */
+        if (IS_GEN_IIE(hpriv))
+            m4 = (m4 & ~0x5DE3FFFC) | (1 << 2);

can this magic number become a named constant? do we know the bits, can they be broken out and enumerated?


--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux