Re: [PATCH 05/37] ata: use get/put_endian helpers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2008-05-29 at 19:52 -0700, Andrew Morton wrote:
> On Thu, 29 May 2008 22:26:18 -0400 Mark Lord <liml@xxxxxx> wrote:
> 

> otoh,
> 
> - I think the args are backwards
> 

It was made to look like put_unaligned_* and put_unaligned()

I think of it as put_le16(source, dest)

> - I don't like the use of the put_*() namespace.  It makes it look
>   like a uaccess operation.

I'm flexible...although I'd probably get nailed to a cross for changing
it again so soon. (the unaligned versions, that is)

Harvey

--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux