> void ata_sff_pause(struct ata_port *ap) > { > ata_sff_altstatus(); > ndelay(400); > } > > and again, if there is no altstatus register, that's a low-level driver > issue. This takes away the ability to shoot yourself directly in the foot and replaces it with the ability to shoot yourself in the foot in a more abstract way. The dma_pause case still needs to check as that is the one where you can make an actual mess but yes it certainly cleans up the others. (Next rev brewing ;)) -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html