On Wed, May 21, 2008 at 09:46:24PM +0900, FUJITA Tomonori wrote: > > No, you misunderstand my question. I meant, software algorithms don't > need ARCH_KMALLOC_MINALIGN alignment for __crt_ctx and if we are fine > with using the ALIGN hack for crypto hardware every time (like > aes_ctx_common), crypto doesn't need ARCH_KMALLOC_MINALIGN alignment > for __crt_ctx. Is this right? The padlock isn't the only hardware device that will require such alignment. Now that we have the async interface there will be more. > Because there are few architecture that defines > ARCH_KMALLOC_MINALIGN. So if crypto hardware needs alignement, it's You keep going back to ARCH_KMALLOC_MINALIGN. But this has *nothing* to do with ARCH_KMALLOC_MINALIGN. The only reason it appears at all in the crypto code is because it's one of the parameters used to calculate the minimum alignment guaranteed by kmalloc. If there were a macro KMALLOC_MINALIGN which did what its name says then I'd gladly use it. Cheeres, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html