Re: [PATCH 4/4] cdrom: revert commit 22a9189 (cdrom: use kmalloced buffers instead of buffers on stack)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jim Paris <jim@xxxxxxxx> wrote:
> Elias Oltmanns wrote:
>> > +	char buffer[255];
>
>> >  	int ret;
>> >  
>> > -	buffer = kmalloc(255, GFP_KERNEL);
>> > -	if (!buffer)
>> > -		return -ENOMEM;
>> > -
>> > -	init_cdrom_command(&cgc, buffer, 4, CGC_DATA_READ);
>> > +	init_cdrom_command(&cgc, &buffer, 4, CGC_DATA_READ);
>> 				 ^
>> Careful here.
>
> They're the same in C.

Oh yes, I see. Sorry for the noise.

Regards,

Elias
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux