Mark Lord wrote:
Check for an empty request queue before stopping EDMA after a FBS-NCQ
error,
as per recommendation from the Marvell datasheet.
This ensures that the EDMA won't suddenly become active again
just after our subsequent check of the empty/idle bits.
Also bump DRV_VERSION.
Signed-off-by: Mark Lord <mlord@xxxxxxxxx>
---
Is DRV_VERSION even useful now?
I could do another patch to just nuke it.
It is standard practice to export all driver versions via dmesg and
modinfo for all libata drivers, so I would prefer that it stay, for
consistency.
Is it useful?
That depends on the maintainer's definition and upkeep of the version
number. If you never update it, of course its useless. If you update
it when the driver achieves certain milestones, i.e. "2.0" when all your
changes are complete, then it may be relevant to you and your userbase.
Version numbers tend to be quite handy because drivers get backported
all over the place, so you might not be able to assume that sata_mv
version 1.21 implies kernel version 2.6.26, for example.
Jeff
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
