Re: [PATCH] libata: Add Intel SCH PATA Support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Also...



Alek Du wrote:
+/*
+ *  Supports:
+ *    Intel SCH (AF82US15W, AF82US15L, AF82UL11L) chipsets
+ */

a link to the public datasheet would be nice, somewhere in a comment


+static const struct pci_device_id sch_pci_tbl[] = {
+	/* Intel SCH PATA Controller */
+	{ 0x8086, 0x811A, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0 },

recommend using PCI_VDEVICE() macro

[and it would be nice if someone converted ata_piix.c, too]


+	{ }	/* terminate list */

+static int __init sch_init(void)
+{
+	int rc;
+
+	rc = pci_register_driver(&sch_pci_driver);
+	if (rc)
+		return rc;
+	in_module_init = 0;
+	return 0;
+}

with the in_module_init thing removed (per Alan's comment), this can become 'return pci_register_driver(...)' nicely


--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux