Mark Lord wrote:
Mark Lord wrote:
...
And for that matter, is it possible for sata_pmp_read() to be called
while the link is active with another command ? Not today, it seems,
but what about when hotplug polling gets implemented ?
..
That's the one I'm most concerned about. Should I be?
...
Tejun,
On a related note, I'm now looking into PMP error handling in the driver.
The obvious thing I see that I want to fix, is that after a media error
on any PMP attached drive, I get this:
ata20.00: failed to read SCR 1 (Emask=0x40)
ata20.01: failed to read SCR 1 (Emask=0x40)
ata20.02: failed to read SCR 1 (Emask=0x40)
ata20.03: failed to read SCR 1 (Emask=0x40)
ata20.04: failed to read SCR 1 (Emask=0x40)
Okay, so those are from sata_pmp_read(), which cannot even
issue it's commands because the port was frozen by the EH.
Is this expected? I'm not entirely clear what to do in
the EH for this driver. The chipset docs say that
after just about any kind of error software must do
a hard reset of the channel to make it usable again.
But I suspect that PIO commands may be okay before that,
and sata_pmp_read() is trying to issue a PIO command.
How to resolve this?
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
