On Friday 22 February 2008, Mark Lord wrote:
> Bartlomiej Zolnierkiewicz wrote:
> > - ide-dma.c is not a separate module
> >
> > - ide-dma.c is not PCI specific anymore
> >
> > - DMA is enabled by default nowadays
> >
> > - link for Intel Zappa BIOS is dead
> >
> > etc.
> >
> > Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@xxxxxxxxx>
> > ---
> > drivers/ide/ide-dma.c | 48 ------------------------------------------------
> > 1 file changed, 48 deletions(-)
> >
> > Index: b/drivers/ide/ide-dma.c
> > ===================================================================
> > --- a/drivers/ide/ide-dma.c
> > +++ b/drivers/ide/ide-dma.c
> > @@ -11,49 +11,6 @@
> > */
> >
> > /*
> > - * This module provides support for the bus-master IDE DMA functions
> > - * of various PCI chipsets, including the Intel PIIX (i82371FB for
> > - * the 430 FX chipset), the PIIX3 (i82371SB for the 430 HX/VX and
> > - * 440 chipsets), and the PIIX4 (i82371AB for the 430 TX chipset)
> > - * ("PIIX" stands for "PCI ISA IDE Xcellerator").
> > - *
> > - * Pretty much the same code works for other IDE PCI bus-mastering chipsets.
> > - *
> > - * DMA is supported for all IDE devices (disk drives, cdroms, tapes, floppies).
> ..
>
> Those top comments still look relevant, or at least as relevant
> as the rest of the file (and subsystem) itself. :)
>
> Sigh.
ide-dma.c supports _much_ more than IDE PCI BM-DMA nowadays :)
[ hmm, it probably makes sense to split CONFIG_BLK_DEV_IDEDMA_SFF code
to a separate file (ide-dma-sff.c?) so ide-dma.c would contain only
generic code ]
anyway here goes "take 2":
[...]
v2:
* Some comments should be preserved. (Noticed by Mark Lord)
Cc: Mark Lord <liml@xxxxxx>
[...]
interdiff:
diff -u b/drivers/ide/ide-dma.c b/drivers/ide/ide-dma.c
--- b/drivers/ide/ide-dma.c
+++ b/drivers/ide/ide-dma.c
@@ -1,9 +1,13 @@
/*
+ * IDE DMA support (including IDE PCI BM-DMA).
+ *
* Copyright (C) 1995-1998 Mark Lord
* Copyright (C) 1999-2000 Andre Hedrick <andre@xxxxxxxxxxxxx>
* Copyright (C) 2004, 2007 Bartlomiej Zolnierkiewicz
*
* May be copied or modified under the terms of the GNU General Public License
+ *
+ * DMA is supported for all IDE devices (disk drives, cdroms, tapes, floppies).
*/
/*
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
