[ Sorry for the late reply. ]
On Friday 04 January 2008, Sergei Shtylyov wrote:
> Bartlomiej Zolnierkiewicz wrote:
>
> > * Fix SWDMA/MWDMA masks in cy82c693_chipset.
>
> > * Add IDE_HFLAG_CY82C693 host flag and use it in ide_tune_dma() to
> > check whether the DMA should be enabled even if ide_max_dma_mode()
> > fails.
>
> I didn't get why this was necessary...
"paranoia" ;-)
Care to send a patch removing it?
> > * Convert cy82c693_dma_enable() to become cy82c693_set_dma_mode()
> > and remove no longer needed cy82c693_ide_dma_on(). Then set
> > IDE_HFLAG_CY82C693 instead of IDE_HFLAG_TRUST_BIOS_FOR_DMA in
> > cy82c693_chipset.
>
> > * Bump driver version.
>
> > As a result of this patch cy82c693 driver will configure and use DMA on
> > all SWDMA0-2 and MWDMA0-2 capable ATA devices instead of relying on BIOS.
>
> > Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@xxxxxxxxx>
>
>
> > Index: b/drivers/ide/pci/cy82c693.c
> > ===================================================================
> > --- a/drivers/ide/pci/cy82c693.c
> > +++ b/drivers/ide/pci/cy82c693.c
> > @@ -1,5 +1,5 @@
> > /*
> > - * linux/drivers/ide/pci/cy82c693.c Version 0.43 Nov 7, 2007
> > + * linux/drivers/ide/pci/cy82c693.c Version 0.44 Nov 8, 2007
> > *
> > * Copyright (C) 1998-2000 Andreas S. Krebs (akrebs@xxxxxxxxxxxxx), Maintainer
> > * Copyright (C) 1998-2002 Andre Hedrick <andre@xxxxxxxxxxxxx>, Integrator
> > @@ -176,14 +176,12 @@ static void compute_clocks (u8 pio, pio_
> > * set DMA mode a specific channel for CY82C693
> > */
> >
> > -static void cy82c693_dma_enable (ide_drive_t *drive, int mode, int single)
> > +static void cy82c693_set_dma_mode(ide_drive_t *drive, const u8 mode)
> > {
> > - u8 index = 0, data = 0;
> > + ide_hwif_t *hwif = drive->hwif;
> > + u8 single = (mode & 0x10) >> 4, index = 0, data = 0;
>
> Useless intializers for 'index' and 'data'.
ditto
Thanks,
Bart
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
