On Friday 15 February 2008, Kamalesh Babulal wrote: > The linux-next-20080215 kernel build fails on the powerpc with > following error > > CC arch/powerpc/platforms/powermac/setup.o > In file included from arch/powerpc/platforms/powermac/setup.c:66: > include/asm/mediabay.h:29: error: syntax error before 'ide_hwif_t' > include/asm/mediabay.h:29: warning: function declaration isn't a prototype > make[2]: *** [arch/powerpc/platforms/powermac/setup.o] Error 1 > make[1]: *** [arch/powerpc/platforms/powermac] Error 2 > make: *** [arch/powerpc/platforms] Error 2 > > This build failure is caused by the ide: rework PowerMac media-bay support > patch.This problem was reported and solution suggested according to > http://lkml.org/lkml/2008/2/13/195 including the > > #include <linux/ide.h> after > > #ifdef CONFIG_BLK_DEV_IDE_PMAC > > helps in fixing the build failure. Thanks, I fixed the original patch. interdiff: [...] v2: * Fix build by adding <linux/ide.h> include to <asm-powerpc/mediabay.h>. (Reported by Michael/Kamalesh/Andrew). Cc: Kamalesh Babulal <kamalesh@xxxxxxxxxxxxxxxxxx> Cc: Michael Ellerman <michael@xxxxxxxxxxxxxx> Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> [...] diff -u b/include/asm-powerpc/mediabay.h b/include/asm-powerpc/mediabay.h --- b/include/asm-powerpc/mediabay.h +++ b/include/asm-powerpc/mediabay.h @@ -23,6 +23,8 @@ extern int media_bay_count; #ifdef CONFIG_BLK_DEV_IDE_PMAC +#include <linux/ide.h> + int check_media_bay_by_base(unsigned long base, int what); /* called by IDE PMAC host driver to register IDE controller for media bay */ int media_bay_set_ide_infos(struct device_node *which_bay, unsigned long base, - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
