Re: [PATCH 2/2] sata_mv: remove iounmap in mv_platform_remove

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



>
>  Mmm.. sounds like a bug to me.  Possibly two bugs:
>
>  1. the ioremap() should fail if the range is already mapped, and
>  2. we should free the resources on module unload.
>
>  I suppose this would be mostly automatic if the code simply
>  were to use devm_ioremap() instead of ioremap().
my understanding for the /proc/iomem was totaly wrong..
the ioremap() actually allocated different address each time, I don't
know if should fail if the range is already mapped, but maybe the name
(remap) hints that it is shouldn't.
anyway, I replaced ioremap with devm_ioremap and it looks fine. I'll
send the new patch in different email.

saeed
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux