On Wed, Feb 13, 2008 at 07:47:11PM +0200, Muli Ben-Yehuda wrote: > On Wed, Feb 13, 2008 at 09:32:03AM -0800, Greg KH wrote: > > > Is there some reason you aren't using the "real" PCI driver api here > > and registering a pci driver for these devices? That would take the > > whole "loop over all pci devices" logic out of the code entirely. > > I recall we had a reason, but I no longer recall what it was. Some > reason the "real" PCI driver API didn't fit at the time. If someone > were to whip up a working patch, I'd happily apply it. "at the time"? It's been in place since the 2.2 days :) Is the problem that other drivers also want access to this PCI device for some reason? I'll whip up a patch for you to test with in a bit... > > > Feel free to nuke it and walk the list forward. > > > > So something like the patch below would be fine? > > Yep, looks good. > > Acked-by: Muli Ben-Yehuda <muli@xxxxxxxxxx> thanks for reviewing this. greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
