Re: [PATCH 4/9] libata: normalize port_info, port_operations and sht tables

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jeff Garzik wrote:
> Tejun Heo wrote:
>> diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
>> index 07dcaf6..08301ca 100644
>> --- a/drivers/ata/ahci.c
>> +++ b/drivers/ata/ahci.c
>> @@ -351,6 +351,8 @@ static const struct ata_port_operations
>> ahci_vt8251_ops = {
>>      .port_suspend        = ahci_port_suspend,
>>      .port_resume        = ahci_port_resume,
>>  #endif
>> +    .enable_pm        = ahci_enable_alpm,
>> +    .disable_pm        = ahci_disable_alpm,
>>  
>>      .port_start        = ahci_port_start,
>>      .port_stop        = ahci_port_stop,
>> @@ -385,6 +387,8 @@ static const struct ata_port_operations
>> ahci_p5wdh_ops = {
>>      .port_suspend        = ahci_port_suspend,
>>      .port_resume        = ahci_port_resume,
>>  #endif
>> +    .enable_pm        = ahci_enable_alpm,
>> +    .disable_pm        = ahci_disable_alpm,
>>  
>>      .port_start        = ahci_port_start,
>>      .port_stop        = ahci_port_stop,
> 
> The last one is probably OK, but I didn't think vt8521 could do this?

I don't know.  Those should be determined by CAP bits and if vt8251 lies
about it, it should be blacklisted by clearing CAP bit as other features.

-- 
tejun
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux