Re: [PATCH 7/9] libata: stop overloading port_info->private_data

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 30 Jan 2008 18:29:01 +0900
Tejun Heo <htejun@xxxxxxxxx> wrote:

> port_info->private_data is currently used for two purposes - to record
> private data about the port_info or to specify host->private_data to
> use when allocating ata_host.


Sensible point, horrible implementation - I'd NAK this strongly in favour
of switching to:

ata_pci_init_one(....., private_ptr);

otherwise when that glue changes we are going to keep having to fix six
or more drivers.

Alan
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux