On Fri, 2008-02-01 at 15:02 -0500, Jeff Garzik wrote: > James Bottomley wrote: > > From: James Bottomley <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx> > > Date: Thu, 10 Jan 2008 11:42:50 -0600 > > Subject: libata: implement drain buffers > > > > This just updates the libata slave configure routine to take advantage > > of the block layer drain buffers. > > > > I suspect I should also be checking for AHCI as well as ATA_DEV_ATAPI, > > but I couldn't see how to do that easily. > > > > Signed-off-by: James Bottomley <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx> > > --- > > drivers/ata/libata-scsi.c | 26 ++++++++++++++++++++++---- > > 1 files changed, 22 insertions(+), 4 deletions(-) > > Tejun's persistent comment/objection with these works is that you need > two sizes, for ATAPI, the raw size and the buffered size. This should be independent of the drain patch. All this one does is eliminate the unnecessary extra segment for alignment. DMA drain for ATAPI is something separate (and it's also something that isn't upstream in any form). James - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
