Re: [PATCH 5/13] ide: add IDE_HFLAG_ERROR_STOPS_FIFO host flag

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 6 Sep 2007 04:13:56 -0400
Jeff Garzik <jeff@xxxxxxxxxx> wrote:

> On Wed, Sep 05, 2007 at 11:52:57PM +0200, Bartlomiej Zolnierkiewicz wrote:
> > 
> > Add IDE_HFLAG_ERROR_STOPS_FIFO host flag and use it instead
> > of hwif->err_stops_fifo.  As a side-effect this change fixes
> > hwif->err_stops_fifo not being restored by ide_hwif_restore().
> > 
> > Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@xxxxxxxxx>
> > ---
> >  drivers/ide/ide-io.c           |    3 ++-
> >  drivers/ide/pci/pdc202xx_new.c |    3 +--
> >  drivers/ide/pci/pdc202xx_old.c |    8 ++++----
> >  include/linux/ide.h            |    3 ++-
> >  4 files changed, 9 insertions(+), 8 deletions(-)
> 
> Hum, I wonder if libata needs something like this.

You'd have to add the drain data on error hack first, right now we will
reset in that case (which for one or two devices has another problem in
that it won't clear a stuck FIFO)

Alan
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux