Re: [PATCH 1/10] ide: use pci_dev->revision

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Bartlomiej Zolnierkiewicz wrote:

Some places were using PCI_CLASS_REVISION instead of PCI_REVISION_ID so
they were not converted by commit 44c10138fd4bbc4b6d6bff0873c24902f2a9da65.

---
Quick grep over kernel tree finds out many other places using either
pci_read_config_dword(dev, PCI_CLASS_REVISION, ...) & 0xff or simply
pci_read_config_byte(dev, PCI_CLASS_REVISION, ...) and they all can be
converted to using dev->revision.

Nice! I was wondering all the time why the revision ID isn't held with he device/vendor IDs (wile being a vital detail for many IDE chips ;-).

Auke, a "PCI_CLASS_REVISION" follow-up to your previous patch would be great.
:)

Acked-by: Sergei Shtylyov <sshtylyov@xxxxxxxxxxxxx>

MBR, Sergei
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux