Alan Cox napsal(a): >>>>> + rebase = pci_iomap(pdev, 0, 0x80); >>>>> t = readl(rebase + CNTRL_REG_OFFSET); >>> Switch to ioread* if you are using the iomap interface. Its not a trivial >> Why, if you know it's surely a mem region (and thus you rely on it and do >> ioremap)? There are many places in the kernel, where this approach is used, e.g. >> libata piix. > > Every single one of them is wrong. The encoding of iomap values is > platform dependant. Fixed in my tree. OK, fast search found these suspicious (not considering e.g. arch/): $ find drivers/ -name '*.c' -exec grep -q pci.*iomap {} \; -a -exec grep -l '\<readl\>' {} \+ drivers/firewire/fw-ohci.c drivers/scsi/sym53c8xx_2/sym_glue.c drivers/media/dvb/pluto2/pluto2.c drivers/media/dvb/b2c2/flexcop-pci.c drivers/ssb/scan.c drivers/char/cyclades.c drivers/char/sx.c drivers/ata/ata_piix.c drivers/ata/sata_inic162x.c drivers/ata/pata_pdc2027x.c drivers/ata/sata_sx4.c drivers/ata/sata_qstor.c drivers/ata/sata_mv.c drivers/ata/sata_svw.c drivers/ata/sata_nv.c drivers/ata/sata_sil.c drivers/ata/sata_vsc.c drivers/ata/sata_promise.c drivers/ata/ahci.c drivers/ata/sata_sil24.c drivers/net/cassini.c drivers/mtd/nand/cafe_nand.c How do you imagine a proper fix? - move to ioreadX/iowriteX or - move back to ioremap (unlikely for the most) or? thanks, -- Jiri Slaby (jirislaby@xxxxxxxxx) Faculty of Informatics, Masaryk University - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html