> That function rocks (except I didn't get what the address setup timings > mean to SW/MW DMA)... They don't, it merges the DMA and PIO ones and you end up with the PIO ones. > > + * Used when configuring the devices ot set the PIO timings. All the > > What's "ot"? to - will fix > > regD |= 0x20 << adev->devno; > > Hm, is setting of "drive DMA capable" bits really needed in the driver. > Doesn't libata core itself do this? For most hardware it doesn't matter. The CMD64x driver code I have all bothers to set it. I don't know if its needed, someone with the bits handy could find out I guess, but if we arent sure it does no harm. - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
