Re: [PATCH 2/2] hpt366: UltraDMA filtering for SATA cards

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Bartlomiej Zolnierkiewicz wrote:

Index: linux-2.6/drivers/ide/pci/hpt366.c
===================================================================
--- linux-2.6.orig/drivers/ide/pci/hpt366.c
+++ linux-2.6/drivers/ide/pci/hpt366.c

[...]

+	case HPT372 :
+	case HPT372A:
+	case HPT372N:
+	case HPT374 :
+		/*
+		 * Check for SATA drive by verifying that the word 93 is 0 and
+		 * the drive is ATA-5 or higher compatible.
+		 */
+		if (id->hw_config == 0 && (id->major_rev_num & 0x7fe0))

Same check as in ide-iops.c::eighty_ninty_three().

Would make sense to add ide_id_is_sata_dev() inline to <linux/ide.h>.

   Right in this patch, or a later cleanup?

I prefer doing it in this patch but later cleanup is also OK...

Alas, you'll have to wait till the next weekend -- the patch doesn't seem to be critical though, it didn't fix the bug... :-]

Thanks.
Bart

MBR, Sergei
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux