On Fri, 10 Aug 2007 19:41:59 +0400
Sergei Shtylyov <sshtylyov@xxxxxxxxxxxxx> wrote:
> Alan Cox wrote:
>
> >>+ if (chip_type == HPT374 && (PCI_FUNC(dev->devfn) & 1)) {
> >>+ struct pci_dev *dev1 = pci_get_slot(dev->bus,
> >>+ dev->devfn - 1);
>
> > Can be NULL
>
> Not really. This may not be called if it's NULL -- see hpt374_init_setup().
> Maybe worth a comment though...
>
> >>+ unsigned long io_base = pci_resource_start(dev1, 4);
>
> > Kaboom
>
> That was a dud bomb. ;-)
What stops a hot unplug of a 374 from causing that to occur. I don't see
where you have the other pci_dev pinned on a hotplug on a box set to scan
the devices in reverse order
(yes its an extremely obscure case ;))
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
