Hello. Bartlomiej Zolnierkiewicz wrote:
I have a feeling that only pdc202xx_new and jmicron drivers actually need this flag (and the latter one actually doesn't care as its methods are empty anyway). Well, AMD/VIA chips enable UltraDMA mode by snooping Set Features command (as the drivers tell them to do so), so the order seems important unless that is changed.
I've mixed it up (again :-): setting the MSB of the UltraDMA registers should be disabling Set Features snooping, so still the flag doesn't seem needed...
Since changing of order affects the way in which hardware is accessed I prefer to keep such changes out of this patch (which is just a cleanup).
I understand.
Could you please handle them in pre or post patch(es)?
More likely in post-patches -- I'll probably be out-of-office for the next several weeks (only appearing at weekends).
Bart
WBR, Sergei - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
