Re: ST340823A disk size issue

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello, I wrote:

diff -ru linux-2.6.22.1/drivers/ide/ide-disk.c linux-2.6.22.1.new/drivers/ide/ide-disk.c --- linux-2.6.22.1/drivers/ide/ide-disk.c 2007-07-10 21:56:30.000000000 +0300 +++ linux-2.6.22.1.new/drivers/ide/ide-disk.c 2007-08-01 22:59:47.000000000 +0300
@@ -502,6 +502,17 @@
              capacity, sectors_to_MB(capacity),
              set_max, sectors_to_MB(set_max));
+ if ((set_max % 2)

I hope gcc will convert this to (set_max & 1) but it wouldn't hurt to code this explicitly.

 && (set_max == capacity + 1)) {

   Wait, isn't set_max an address of a last sector,

Well, I was wrong: idedisk_read_native_max_address*() increments this value bofore returning.

and isn't capacity a sector count? Shouldn't it be (set_max == capacity)?

   No, it was OK.

 MBR, Sergei

-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux