Tejun Heo wrote:
Jeff Garzik wrote:
Tejun Heo wrote:
Jeff, Mark, are you guys okay with the modified version?
Close! Thanks for revising!
My only comment now is that I dislike atapi_scmd85. That means nothing
to me.
I liked the old name better. Or maybe use atapi_passthru16.
The problem with ata16_passthru is that it suggests the opposite of what
it does. The default value 0 allows ATA_16 passthrough command while
setting it to 1 disallows ATA_16 passthrough and passes through SCSI
Command 0x85 which shares command byte with ATA_16. Maybe it's because
I'm not a native speaker but the last sentence is pretty difficult to
digest. So, IMHO, atapi_scmd85 is slightly better in that it means
nothing rather than suggesting the opposite.
Thanks for plugging away at this one, Tejun.
And I do agree that ata16_passthru sounds backwards of what it really does.
There's got to be a nicer name for this thing.
In practice, I doubt that anyone will ever use the parameter,
so it really doesn't matter a whole lot what we call it.
But something sensible would be nice.
There's got to be a shorter version of "atapi_pass_opcode_0x85_to_device=1".
Perhaps "atapi_op_85_passthru=1" or "atapi_passthru_op_85=1" ??
Also, this is an example of something that is really a "per device"
parameter, rather than a global. But we haven't yet cracked a good way
to do that yet in libata.
Cheers
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
