On Thu, 2007-07-26 at 20:04 +0200, Bartlomiej Zolnierkiewicz wrote: > On Tuesday 24 July 2007, Benjamin Herrenschmidt wrote: > > On Tue, 2007-07-24 at 00:29 +0200, Bartlomiej Zolnierkiewicz wrote: > > > Use ide_config_drive_speed() instead of pmac_ide_do_setfeature() and remove > > > the latter, also ide-iops.c::__ide_wait_stat() could be static again. > > > > > > Since for IDE PMAC host driver IDE_CONTROL_REG is always true, device's > > > ->quirk_list is always zero and ->ide_dma_host_{on,off} are nops than > > > the only changes in behavior are: > > > > > > * if PIO mode is set then ->dma_off_queitly is called to disable DMA > > > > > > * if setting transfer mode fails ide_dump_status() is called to dump status > > > > I'll test that today. > > ping? Oops, sorry, got delayed by urgent work things among others. I'll get back to that today or next week, not sure yet. BTW. It might make my life easier if you could email me a tarball of your full current quilt serie :-) Cheers, Ben. - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html