Disabling ADMA? (was Re: [PATCH] drivers/ata: Add the SW NCQ support to sata_nv for MCP51/MCP55/MCP61)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Kuan Luo wrote:
	@@ -1714,3 +2761,6 @@ module_init(nv_init);
	 module_exit(nv_exit);
	 module_param_named(adma, adma_enabled, bool, 0444);
	 MODULE_PARM_DESC(adma, "Enable use of ADMA (Default: true)");
	+module_param_named(ncq, ncq_enabled, bool, 0444);
	+MODULE_PARM_DESC(ncq, "Enable use of NCQ (Default: false)");

After looking through sata_nv bug reports, I am leaning towards disabling ADMA by default, and wanted to solicit comments.

While admittedly not knowing the root cause, it seems like every current outstanding sata_nv bug report that remains after switching out hardware can be solved by setting module option 'adma' to zero. That's my first suggestion upon any bugzilla sata_nv bug, and it usually works. You can look through bugs assigned to or CC'd to jgarzik@xxxxxxxxx (kernel.org bugs) jgarzik@xxxxxxxxxx (redhat.com bugs) for examples.

I still need to review the SWNCQ patch in detail, but I presume it is possible to still use SWNCQ without ADMA?

On a side note, I would rather default SWNCQ to 'on'.

	Jeff




-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux