Re: [PATCH 9/15] ide: add PIO masks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Bartlomiej Zolnierkiewicz wrote:

* Add ATA_PIO[0-6] defines to <linux/ata.h>.

* Add ->pio_mask field to ide_pci_device_t and ide_hwif_t.

* Add PIO masks to host drivers.

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@xxxxxxxxx>

  Not sure if my ACK applies now...

Index: b/drivers/ide/pci/jmicron.c
===================================================================
--- a/drivers/ide/pci/jmicron.c
+++ b/drivers/ide/pci/jmicron.c
@@ -180,6 +180,7 @@ fallback:
		.autodma	= AUTODMA,		\
		.bootable	= ON_BOARD,		\
		.enablebits	= { {0x40, 1, 1}, {0x40, 0x10, 0x10} }, \
+		.pio_mask	= ATA_PIO5,		\
	}

Just noticed that this driver does nothing in its tuneproc() method. So, this mask is unrealistic. The method needs to be dropped for now along with

Adding ->pio_mask doesn't change the old behavior in _any_ way.

   Of course not. That's why I didn't NAK. :-)

config-jmicron_chipset_for_pio() -- ptobably, with FIXME added.

Please see comments for jmicron_tune_chipset(), ->tuneproc just misses

   Ah, the case of overly smart chipset!

setting transfer mode on the device.  Care to send a patch fixing it?

   I don't care about JMicron, so only when/if I'll find some time...

Thanks,
Bart

WBR, Sergei
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux