Jeff Garzik wrote: > Tejun Heo wrote: >> If SError isn't accessible, EH can't tell whether hotplug has happened >> or not. Report SError read failure with AC_ERR_OTHER and schedule >> probing with hardreset. This will be mainly useful for PMPs. >> >> Signed-off-by: Tejun Heo <htejun@xxxxxxxxx> >> --- >> drivers/ata/libata-eh.c | 6 +++++- >> 1 files changed, 5 insertions(+), 1 deletions(-) > > What if the LLDD told us hotplug happened? > > Even though sata_promise has SError, it should be noted that hotplug > under sata_promise is not signalled through normal means, but by a > special vendor-specific register Those two are independent and doesn't interfere with each other. This is just safeguard against PMP SCR read failures which might or might not imply phy event. ie. it's just another source of hotplug event. -- tejun - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
