Jeff Garzik wrote: > Tejun Heo wrote: >> Update formatting for LLD provided error descriptions such that... >> >> * No default () around it >> * Each element is separated by <> not , >> >> This change makes each element responsible for putting a space after >> itself instead of before - e.g. "<elem> " not ", elem". This is more >> conventional and allows more flexible combination of messages. >> >> Signed-off-by: Tejun Heo <htejun@xxxxxxxxx> > > either way, it is messy. > > I guarantee that programmers are not going to remember always to add a > "magic space" after certain error descriptions. It is far, far better > for the upper layer to help out a bit, and insert a space and/or comma > for the LLDD. After all, the LLDD might not be the only one printing > error messages at that time; the upper layer might also wish to do so in > the same dmesg line. Okay then, I guess it's __ata_ehi_push_desc()/ata_ehi_push_desc() time, where the prefixed one is the raw one and the latter one is with automatic "<> " added. Will fix. -- tejun - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
