Jeff Garzik wrote:
> Tejun Heo wrote:
>> +++ b/include/linux/libata.h
>> @@ -322,7 +322,8 @@ enum ata_completion_errors {
>> AC_ERR_SYSTEM = (1 << 6), /* system error */
>> AC_ERR_INVALID = (1 << 7), /* invalid argument */
>> AC_ERR_OTHER = (1 << 8), /* unknown */
>> - AC_ERR_NODEV_HINT = (1 << 9), /* polling device detection hint */
>> + AC_ERR_NCQ = (1 << 9), /* marker for offending NCQ qc */
>> + AC_ERR_NODEV_HINT = (1 << 10), /* polling device detection
>> hint */
>
>
> patch is OK, except for the above very-minor flaw: to remind, do not
> re-arrange bit numbers in the same patch you are adding bits. it makes
> the patch more difficult to read. Just add the new bit at the end.
>
> If you wish to re-arrange the bits, do it in a separate patch (though I
> see no need for re-arranging)
Indeed, I didn't mean to rearrange them. Probably just slipped through
while editing. Will fix.
--
tejun
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
