Re: [PATCH 2.6.22-rc5] libata: be less verbose about hpa

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Alan Cox wrote:
> On Mon, 25 Jun 2007 20:45:54 +0900
> Tejun Heo <htejun@xxxxxxxxx> wrote:
> 
>> There's no reason to print out hpa related messages when HPA is not
>> active.  Kill the unconditional message and add a warning message
>> which is printed if HPA size is smaller than the current size.
>>
>> Signed-off-by: Tejun Heo <htejun@xxxxxxxxx>
> 
> Acked-by: Alan Cox <alan@xxxxxxxxxx>
> 
> (Should it be a dprintk instead of vanish though ?)

I thought about doing KERN_DEBUG but we have printks for both hpa >
current and hpa < current, so if no message is printed hpa == current
and the current sectors is printed in the next line anyway, so I think
we can just drop it.

-- 
tejun
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux