I don't think we want to have the same DeviceID supported in more then one driver. Would they not conflict with each other? Jason >-----Original Message----- >From: chunkeey@xxxxxx [mailto:chunkeey@xxxxxx] >Sent: Monday, June 18, 2007 11:50 AM >To: Gaston, Jason D >Cc: linux-ide@xxxxxxxxxxxxxxx >Subject: Re: libata: ATA_PIIX missing ICH8M PCIIDs. > >On Monday, 18. June 2007, Gaston, Jason D wrote: >> FYI: DID 2850 is the PATA IDE controller. Most likely, the laptop does >not have SATA drives and is running off of PATA. >> >> The old IDE subsystem (piix.c) is where I added that PATA DID to. >> #define PCI_DEVICE_ID_INTEL_ICH8_6 0x2850 in pci_ids.h >> >> Jason >> > >Yes, I've already said that the old IDE subsystem knows about ICH 8M >(read the stuff in the brackets in the original post!). > >But one day the old ide subsystem will be gone... >that's why I've added the PCIID to ata_piix.c "today", so I don't have to >do it "tomorrow". > >Another thing, Kconfig's description clearly states: " >config ATA_PIIX > tristate "Intel ESB, ICH, PIIX3, PIIX4 PATA/SATA support" >... > This option enables support for ICH5/6/7/8 Serial ATA > and support for PATA on the Intel ESB/ICH/PIIX3/PIIX4 series > host controllers. >" > >so, either change the description to: >"... support for PATA on the Intel ESB/ICH(all old chipsets >0,2,3M,3,4,5,6,7,7-R; but >not 8M, because you have use the old subsystem, for your "new" >technology!)/PIIX3/PIIX4 series" > >or accept the 1+1=2 logic and merge the patch into the git. >(hint: but only after changing ich_pata_100 to ich_pata_133 of course!) > >:D > >Thanks, > Chr. > >> >> >On Monday, 18. June 2007, Alan Cox wrote: >> >> On Mon, 18 Jun 2007 15:20:06 +0200 >> >> Chr <chunkeey@xxxxxx> wrote: >> >> >> >> > Hi, >> >> > >> >> > I got a new laptop and I had a little problem that the DVD drive >wasn't >> >recognized by >> >> > libata's piix driver (but the old IDE Subsystem found it!). >> >> > >> >> > So, after adding the new pciid 8086:2850 it works! >> >> > But, I don't know if it's ich_pata_100 or ich_pata_133 since the >> >> > dvd/cd drives only goes up to udma2 speeds. >> >> >> >> Its ich_pata_133 - all the newer chips are. They work even better if >you >> >> set them into AHCI mode in the BIOS and then they should "just work" >with >> >> recent kernels as the AHCI driver now matches by class. >> >> >> >> Alan >> >> >> >> >> > >> >No go.. I've tried 2.6.20-1-amd64 (debian sid) and a vanilla 2.6.22-rc5. >> > >> >(The "problem" is that there are no options for that in the BIOS. >> >The BIOS itself is only useful on these laptops, if you want to set a >BIOS >> >password, setting the system clock or change the boot order... and >nothing >> >else) >> > >> >Thanks, >> > Chr. >> >- - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
