Re: [PATCH 1/6] libata: update protocol numbers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Mark Lord wrote:
Jeff Garzik wrote:
Albert Lee wrote:
Patch 1/6:
 Update the ATA passthru protocol numbers according to the new spec.

Signed-off-by: Albert Lee <albertcc@xxxxxxxxxx>

applied 1-4, 6 to #upstream-fixes

What about this one:  [PATCH 5/6] libata: support ATAPI devices  ??

I'm quite happy to let Albert run with that,
as he's busily maintaining the rest of the passthrough stuff.

I answered this a month or so ago, but between your lost mail and my apparently-lossy Sent folder, it would probably be worth re-answering:

Rather than sprinkling "is it ata or atapi?" tests throughout the libata-scsi hotpaths, I would strongly prefer that
__ata_scsi_queuecmd() change to look more like

	if (device is ATA)
		xlat_func = ata_get_xlat_func()
		if (xlat_func)
			ata_scsi_translate()
		else
			ata_scsi_simulate()
	else
		xlat_func = atapi_get_xlat_func()
		if (xlat_func)
			atapi_scsi_translate()
		else
			atapi_scsi_simulate()

and then make the changes that logically fall from that.

	Jeff


-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux