Tomasz Chmielewski wrote:
Jeff Garzik schrieb:
Below is a refresh of my on-going effort to convert sata_mv to the new
exception handling framework. sata_mv is one of the last hold-outs, and
its old-EH implementation blocks new features like hotplug and NCQ.
It works for me on the one 50xx and one 60xx card I tested it on, but
other testers reported regressions, which is why it is not yet upstream.
Hi,
If I'm correct, this patch won't make to 2.6.22, and the first possible
inclusion would be 2.6.23?
Correct... if that. No guarantee it will make 2.6.23 either, since it
is low priority :(
Could you summarize what other regressions were reported? I can't find
much information about sata_mv regressiobs on linux-ide list (at least
when looking at the subjects: lots of patches from you, and two reports
from me).
Dave Dillow and dean gaudet responded with reports that the
BUG_ON/WARN_ON traps in would trigger:
WARNING: at drivers/ata/sata_mv.c:1287 mv_qc_issue()
and
WARNING: at drivers/ata/sata_mv.c:1333 mv_get_crpb_status()
which leads me to think that my sata_mv new-EH patches are accidentally
turning on NCQ mode.
I have a feeling that I will be able to reproduce this once I attach an
NCQ-capable drive and re-test on my own systems, but again, haven't
found the time :/
Jeff
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
