Hi, On Tuesday 22 May 2007, Junio C Hamano wrote: > Earlier, the matching of (model,rev) in ide-dma black/white list > handling was to consider "ALL" in the table to match any > revision. This changes the wildcard to NULL. This way, the > DMA_BLACK_LIST macro used in the previous patch does not have to > use a slightly funky compile time constant expression to convert > NULL to "ALL". > > Signed-off-by: Junio C Hamano <junkio@xxxxxxx> The change itself looks good but IMO it is worth doing it before patch #2/3 (it would also make it possible for me to merge this patch immediately). When it comes to patch #2 - Alan's comment may be a bit harsh but he seems to be right - there should be a common library-like file (ata-blacklist.c or ata-quirks.c or whatever name you like) containing ata_device_blacklist[]. This would require slight modification of ide_in_drive_list() to teach it about ATA_HORKAGE_DMA but as I see from this patch this shouldn't be a problem for you. ;) Please also note that <linux/ata.h> is used by both IDE and libata so it should be a good place to put struct ata_blacklist_entry and ATA_HORKAGE_* macros. Care to respin both patches? > * I do not really know what I am doing in the mips area, but > that architecture specific table seems to be used by the same > ide_in_drive_list() function, so the entries are matched to > the updated code. Yep, thanks for not breaking AMD Alchemy IDE suppport. It looks like au1xxx_ide.h should really be in drivers/ide/mips because it is only included from drivers/ide/mips/au1xxx_ide.c - could somebody verify this and send me a patch? Thanks, Bart - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
