Benjamin Herrenschmidt wrote:
On Fri, 2007-05-25 at 00:26 -0400, Jeff Garzik wrote:
Just replace the ata_std_softreset() call with code that does MMIO
flushes on a safe register?
Yeah well... if just reading altstatus is enough, I don't see the point
of doing anything MMIO-dependant or whatever. I can just add reading of
it after all 3 SRST bit toggles unconditionally.
Sorry, to be clear I would not want to change the core code to bang
AltStatus in the middle of the SRST twiddles...
The core code only fails (in theory) for PATA+MMIO cases, and the
easiest fix should be to read some innocuous vendor-specific register.
That allows the core code to stay unchanged, requiring only two drivers
(pdc and sil680) to be updated with this flushing behavior.
All other discussion of ata_pause() seemed like an unrelated side
discussion, unless I missed something?
Jeff
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
