Re: [PATCH] libata: Allow a controller specific post bus reset method

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> ata_bus_post_reset() is a separate function only because it was written
> that way at the beginning.  It's really not a separate logical API and I
> was thinking of folding it into ata_bus_softreset() or
> ata_std_softreset() after old EH is gone.  Also it's a bit ugly to call
> ap->ops->* from a ap->ops callback.  I think the correct solution here
> is to write a separate ->softreset method.

It means copying a lot of code but I can do

> Hmmm... I guess what's failing is the nsect==1 && lbal==1 test, right?

Yep

> Jeff, do we really need that test?  dev0 doesn't clear BSY till PDIAG-
> is asserted from dev1 anyway.  Maybe just limit the waiting there to a
> few secs?

Alan
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux