patch 5/8: - Move the ATA_TFLAG_POLLING check from ata_interrupt to ata_host_intr - Ack unsolicited INTRQ if polling and before the HSM accessing the port. (e.g. some device asserts INTRQ even if polling and nIEN = 1.) Signed-off-by: Albert Lee <albertcc@xxxxxxxxxx> Cc: Alan Cox <alan@xxxxxxxxxxxxxxxxxxx> Cc: Tejun Heo <htejun@xxxxxxxxx> --- 1. This fixes the Benq "irq nobody cared" problem. (Some device asserts INTRQ even if nIEN = 1 and polling. http://bugzilla.kernel.org/show_bug.cgi?id=8441) Other unsolicited irqs that Alan concerned about will be address in patch 8/8. 2. Per Tejun's advice, I have checked the LLDDs. The following LLDDs checks ATA_TFLAG_POLLING in their interrupt handler: pdc_adma, sata_inic162x, sata_mv, sata_nv, sata_promise, sata_qstor, sata_sil, sata_sx4 and sata_vsc. After review, it seems non of them requires change due to this patch. BTW, sata_sil and some other LLDDs already have such workaround in it. diff -Nrup 04_move_narrow_lock/drivers/ata/libata-core.c 05_polling_ack/drivers/ata/libata-core.c --- 04_move_narrow_lock/drivers/ata/libata-core.c 2007-05-16 13:53:16.000000000 +0800 +++ 05_polling_ack/drivers/ata/libata-core.c 2007-05-16 13:53:20.000000000 +0800 @@ -5694,6 +5694,13 @@ inline unsigned int ata_host_intr (struc if (ap->pflags & ATA_PFLAG_HSM_WQ) goto idle_irq; + /* polling, while HSM not yet active in wq */ + if (qc->tf.flags & ATA_TFLAG_POLLING) { + /* ack unsolicited irq */ + ata_chk_status(ap); + goto idle_irq; + } + /* Check whether we are expecting interrupt in this state */ switch (ap->hsm_task_state) { case HSM_ST_FIRST: @@ -5804,8 +5811,7 @@ irqreturn_t ata_interrupt (int irq, void struct ata_queued_cmd *qc; qc = ata_qc_from_tag(ap, ap->active_tag); - if (qc && (!(qc->tf.flags & ATA_TFLAG_POLLING)) && - (qc->flags & ATA_QCFLAG_ACTIVE)) + if (qc && (qc->flags & ATA_QCFLAG_ACTIVE)) handled |= ata_host_intr(ap, qc); } } - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
