On Tue, 2007-05-15 at 07:08 -0400, Alan Cox wrote: > On Tue, May 15, 2007 at 04:11:23PM +1000, Benjamin Herrenschmidt wrote: > > + if (!try_mmio) > > + goto use_pio; > > Please use a different naming scheme "PIO" means something quite different > in ATA Indeed, the naming's a bit confusing, I'll fix that. > Rest looks fine although I'd be interested to know if you can measure any > performance change. Nothing significant here on the box but I had cases of setups where there was simply no IO space accessible on the PCI bus (one of the reason for using a controller that does MMIO). Cheers, Ben. - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
