Tejun, The future nvidia chips are all base on AHCI and also they can support compatible mode,but current sata_nv have the bug with compatible mode for AHCI controller,we need to modify the sata_nv driver then submit the patch. Before that,if users load the sata_nv driver for our AHCI controllers,they will encounter that bug. BRs Peer Chen -----Original Message----- From: Tejun Heo [mailto:htejun@xxxxxxxxx] Sent: Friday, May 11, 2007 7:49 PM To: akpm@xxxxxxxxxxxxxxxxxxxx; Peer Chen Cc: jeff@xxxxxxxxxx; linux-ide@xxxxxxxxxxxxxxx Subject: Re: [patch 08/20] drivers/ata: remove the wildcard from sata_nv driver akpm@xxxxxxxxxxxxxxxxxxxx wrote: > From: "Peer Chen" <pchen@xxxxxxxxxx> > > Because nvidia SATA controllers onward base on AHCI, so wildcard in sata_nv > driver is unnecessary. Also the wildcard sometimes cause sata_nv driver to > be loaded for AHCI controllers,which is not as expected. > > Signed-off-by: Peer Chen <pchen@xxxxxxxxxx> > Cc: Tejun Heo <htejun@xxxxxxxxx> > Cc: Jeff Garzik <jeff@xxxxxxxxxx> > Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> Peer Chen, are you sure we don't miss any existing devices by doing this? Also, what would future nvidia chips look like? AHCI only or dual mode similar ICHs? If compatible mode is going to be supported && there is no switch we can mangle from PCI quirks to put it into AHCI mode, we might wanna keep PCI_CLASS_STORAGE_IDE assuming compatible mode interface remains similar. Thanks. -- tejun ----------------------------------------------------------------------------------- This email message is for the sole use of the intended recipient(s) and may contain confidential information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply email and destroy all copies of the original message. ----------------------------------------------------------------------------------- - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
