Mikael Pettersson wrote:
The sata_promise error decode update changed pdc_host_intr() to return and not complete the qc after detecting an error. Unfortunately not completing the qc:s causes them to always time out on error, which is wrong and has nasty side-effects. This patch updates pdc_error_intr() to call ata_port_abort(), similar to ahci and sata_sil24. Doing this is important as it makes EH see the original error and not a bogus timeout. Signed-off-by: Mikael Pettersson <mikpe@xxxxxxxx> --- Thanks to Tejun for educating me about the significance of ata_port_abort()/ata_port_freeze() in ahci and sata_sil24's error intr paths. drivers/ata/sata_promise.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletion(-)
applied 1-2... - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
