On Sat, 05 May 2007 17:30:51 +0200, Tejun Heo wrote: > Mikael Pettersson wrote: > >> I.e. no freezing of ports... > > > > Your patch to delete the 'return 1;' on error is correct, > > and makes the code match exactly the behaviour of previous > > versions of sata_promise, except for the additional error > > decoding. > > > > ahci and sata_sil24 do the return in this situation. I don't > > yet understand why they can get away with it while sata_promise > > cannot, but for now the return should be removed. > > That's because sata_sil24 and ahci call either ata_port_abort() or > ata_port_freeze() prior to finishing error_intr routine. Both functions > abort all in-flight command and schedule EH. Ah. Thanks, that clarifies things. Jiri: please test the patch below instead. That is, revert to the original code _with_ the 'return 1;', and then add this patch to it. It should have pretty much the same effect as removing the 'return 1;', however calling ata_port_abort() is more in line with libata's new-style error handling. /Mikael --- linux-2.6.21-mm1/drivers/ata/sata_promise.c.~1~ 2007-05-05 22:24:41.000000000 +0200 +++ linux-2.6.21-mm1/drivers/ata/sata_promise.c 2007-05-05 22:25:21.000000000 +0200 @@ -653,6 +653,8 @@ static void pdc_error_intr(struct ata_po qc->err_mask |= ac_err_mask; pdc_reset_port(ap); + + ata_port_abort(ap); } static inline unsigned int pdc_host_intr( struct ata_port *ap, - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
