On Wed 2006-07-26 17:29:33, David Brownell wrote: > On Wednesday 26 July 2006 2:02 am, Pavel Machek wrote: > > Hi! > > > > > > and please don't do this. Suspend-to-disk will call > > > > amd74xx_resume when it needs to talk to the disk. > > > > > > I don't understand the rest of this comment. That code looks > > > correct (other than calling the goofy/broken pci_choose_state thing); > > > PM_EVENT_FREEZE and PM_EVENT_PRETHAW should not disable the device. > > > > Well, I'd prefer PM_EVENT_FREEZE and PM_EVENT_SUSPEND to be the same > > code (i.e. remove the if() and just do > > > > > > > + pci_disable_device(dev); > > > > > + pci_set_power_state(dev, pci_choose_state(dev, state)); > > > > unconditionaly). It should also work, and not really be slower. > > Oh, I see. But wouldn't that cause FREEZE to spin down the drives? I do not think so. If it will, I'm obviously wrong and original version is okay. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html - : send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
