Hello, all In ACPI spec 3.0, section 9.9 defines 4 objects for PATA/SATA: _GTF is for both PATA and SATA, which is used to return ATA task file needed to re-init the drive; _SDD is SATA-only object, which is used to inform the platform of the type of device attached to a port; _GTM and _STM are PATA-only objects, which are used to get/set PATA timing information(i.e. PIO and DMA speed). In this patch set, ata_acpi_exec_tfs() is for getting ATA task file from _GTF and executing them for a given drive; ata_acpi_push_id() is for setting _SDD. NOTE: this patch doesn't include the support for _GTM and _STM because libata defines ->set_piomode(), ->set_dmamode() callbacks for LLDD, which do the same work as _GTM and _STM. So I think it's not necessary to provide redundant functionality by _GTM and _STM. Randy, I'll add your sign-off line after you review the patch. Thanks, Forrest - : send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html