Re: [PATCH 04/12] libata: implement ata_all_ports list

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Tejun Heo wrote:
Implement ata_all_ports list.  All active ata_ports are linked on this
list.  This will be used to dynamically modify libata-wide
configurations.

Signed-off-by: Tejun Heo <htejun@xxxxxxxxx>

---

 drivers/scsi/libata-core.c |   13 +++++++++++++
 include/linux/libata.h     |    2 ++
 2 files changed, 15 insertions(+), 0 deletions(-)

a962488760934f639dd202793694339afd2db1cf
diff --git a/drivers/scsi/libata-core.c b/drivers/scsi/libata-core.c
index 61db4f5..1477d32 100644
--- a/drivers/scsi/libata-core.c
+++ b/drivers/scsi/libata-core.c
@@ -70,6 +70,9 @@ static unsigned int ata_dev_init_params(
 static unsigned int ata_dev_set_xfermode(struct ata_device *dev);
 static void ata_dev_xfermask(struct ata_device *dev);
+static DEFINE_MUTEX(ata_all_ports_mutex);
+static LIST_HEAD(ata_all_ports);

NAK. I'm pretty strongly against things that cross the controller boundary. Any information or data structure shared across multiple controllers often winds up unnecessary limiting future implementations, and become locking/serialization nightmares.


-
: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux